[ANCHOR-526] Fix account not being forwarded in SEP-9's /customer callback #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
lijamie98
reviewed
Nov 1, 2023
| @@ -104,7 +109,7 @@ String constructToken( | |||
| return jwtService.encode(token); | |||
| } | |||
|
|
|||
| void forwardKycFields(Map<String, String> request) throws AnchorException { | |||
| void forwardKycFields(Map<String, String> request, Sep10Jwt jwt) throws AnchorException { | |||
There was a problem hiding this comment.
The memo and account are not KYC fields. Can we add them after line#58?
There was a problem hiding this comment.
Put customer request is being created inside forwardKycFields method, so it's required to pass extra parameter either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix account not being forwarded in SEP-9's /customer callback
Context
When receiving callback for SEP-9 field forwarding all JWT fields (account and memo) was missing. Turned out, they were not being forwarded properly
Testing
./gradlew testDocumentation
There is a task for documenting this feature
Known limitations
N/A