-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Merge develop
into sep-6
#1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tellar#1169) ### Description Add `home_domains` to SEP-10 to take a list of domains, Rename `Sep10Config::getHomeDomain()` to `Sep10Config::getHomeDomains()` to always return a list of available domains `home_domain` and `home_domains` cannot coexist in Sep10Config, this is comment in default-value.yml, also enforced in validation rules `web_auth_domain` will be required if there are more than 1 home domain specified in `home_domains` ### Context The SDP multi-tenant integration will rely on multiple toml files, so we’ll need the Anchor Platform to accommodate that by allowing multiple home_domains to be configured, in the format of a comma-separated list of domains. ### Testing - `./gradlew test` --------- Co-authored-by: Jamie Li <[email protected]>
### Description Change PR template to account for documentation changes
…tellar#1173) ### Description Extract the test concurrency settings to `scripts.gradle.kts` file
…ellar#1176) ### Description Fix `SimpleMoreInfoUrlConstructorTest` calendar skew ### Context The tests in `SimpleMoreInfoUrlConstructorTest` calls Calendar which may be statically mocked by other concurrent tests. Add `@LockStatic` to avoid the conflict.
…lar#1178) ### Description add `withdraw_anchor_account` to `PATCH /transactions` to support setting destination accounts for withdrawals dynamically ### Context Today, the Anchor Platform sets `withdraw_anchor_account` to the value of the asset’s distribution account set in the config when the transaction is created. Per partner request, support setting `withdraw_anchor_account` via `PATCH /transactions` – the address set can be different from the configured distribution account for the asset ### Testing - `./gradlew test` - Added test case to verify `withdraw_anchor_account` is updated via patch /transaction
philipliu
force-pushed
the
sep-6-10-30-merge
branch
2 times, most recently
from
October 30, 2023 17:38
068cf4f
to
b42448f
Compare
philipliu
force-pushed
the
sep-6-10-30-merge
branch
from
November 1, 2023 17:34
2235b25
to
bfa145f
Compare
JiahuiWho
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
develop
intosep-6
.Context
Keep
sep-6
branch up to date.Testing
./gradlew test
Documentation
N/A
Known limitations
N/A