Extract the test concurrency settings to scripts.gradle.kts file
#1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijamie98
force-pushed
the
feature/chore-move-parallelism-to-root-project
branch
from
0994aea to
7e77882
Compare
lijamie98
changed the title
scripts.gradle.kts file
…rallelism-to-root-project
JiahuiWho
reviewed
Oct 25, 2023
| // shorten the overall test time. | ||
| systemProperty( | ||
| "junit.jupiter.testclass.order.default", | ||
| "org.junit.jupiter.api.ClassOrderer\$OrderAnnotation" |
There was a problem hiding this comment.
Just curious why not include this in scriptw.gradle.kts?
There was a problem hiding this comment.
Yeah, that kind of make sense too. But it is not part of enableConcurrency. But we may refactor in the future if we think we should extract this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the test concurrency settings to
scripts.gradle.ktsfileContext
Refactoring
Testing
./gradlew test