Fix potential uninitialized array access.

stella-emu · Dec 11, 2024 · 4ba7bfd · 4ba7bfd
1 parent 9141731
commit 4ba7bfd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/os/windows/FSNodeWINDOWS.cxx b/src/os/windows/FSNodeWINDOWS.cxx
@@ -152,11 +152,11 @@ bool FSNodeWINDOWS::getChildren(AbstractFSList& myList, ListMode mode) const
   else
   {
     // Drives enumeration
-    TCHAR drive_buffer[100];
-    GetLogicalDriveStrings(sizeof(drive_buffer) / sizeof(TCHAR), drive_buffer);
+    static std::array<TCHAR, 100> drive_buffer;
+    GetLogicalDriveStrings(static_cast<DWORD>(drive_buffer.size()), drive_buffer.data());
 
-    char drive_name[2] = { '\0', '\0' };
-    for (TCHAR *current_drive = drive_buffer; *current_drive;
+    static char drive_name[2] = { '\0', '\0' };
+    for (TCHAR* current_drive = drive_buffer.data(); *current_drive;
          current_drive += _tcslen(current_drive) + 1)
     {
       FSNodeWINDOWS entry;