Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtatsu formula #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add libtatsu formula #62

wants to merge 1 commit into from

Conversation

unilock
Copy link

@unilock unilock commented Sep 19, 2024

idevicerestore and libimobiledevice have a new compile time dependency: libtatsu.
This PR adds a formula for it and adjusts the dependencies of other formulae appropriately.

@unilock
Copy link
Author

unilock commented Sep 19, 2024

It appears that keg_only must be commented out for any other formula to successfully recognize libtatsu as installed. Notably, libtatsu is not yet present in homebrew/core.
(I was using the old version of a formula, that didn't declare a dependency on libtatsu...)

Comment on lines +14 to +18
# bottle do
# root_url "https://github.com/stek29/homebrew-idevice/releases/download/libirecovery-1.1.0-25-g447ae09"
# sha256 cellar: :any, arm64_sonoma: "3a3b9c1c585ab8fd269768d317559d486c0f0fb34fc94e885f4ee4a55f51f038"
# sha256 cellar: :any, ventura: "839aa7ff745790403e66f3ac5d114480d07d9ae25b4c6bead9bfc8571de9e82c"
# end
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this section

Comment on lines +4 to +6
url "https://github.com/libimobiledevice/libtatsu.git",
revision: "e3eb2e224781f6522e2cf63c35c2c249747d648d"
version "1.0.3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since tagged release version is used, please replace it with a url to a specific version – see fsmon for example
something like this:

url "https://github.com/libimobiledevice/libtatsu/archive/refs/tags/1.0.3.tar.gz"
sha256 "3e039497bb90439dc01ead2b78ccbdf76dfce21b3fdd8f21a1ac584934e33a44"

--disable-silent-rules
]

system "./autogen.sh", *std_configure_args, *args
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you replace sha revision with a tagged tarball, replace autogen.sh with ./configure too

@stek29
Copy link
Owner

stek29 commented Sep 24, 2024

wow, thank you and sorry for the long wait!

I've left some comments, I can fix them up myself and get this merged, if you're ok with that.

@unilock
Copy link
Author

unilock commented Oct 10, 2024

@stek29 Sorry, I've been away from a computer for the past two and a half weeks :p

Please do feel free to fix up what you pointed out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants