Support multi-app completion hook generation (not default behavior) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +131,12 @@ public function generateHook($type, $programPath, $programName = null) | |||
| // Use the program path if an alias/name is not given | |||
| $programName = $programName ?: $programPath; | |||
|
|
|||
| if ($multiple) { | |||
| $completionCommand = '${1} _completion'; | |||
There was a problem hiding this comment.
{$1} works under BASH, but doesn't resolve to anything under ZSH. Just using $1 works correctly on both BASH and ZSH.
There was a problem hiding this comment.
Thanks for checking that out.
There was a problem hiding this comment.
That's the first thing I've checked before wanting to to ask you why you've merged this PR and checked the merge result to find the error instead tell me to fix that and merging only afterwards.
aik099
deleted the
44-support-completion-wrapper-for-multi-app-completion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--multiple|-moption is added, that will:$1(the path of app user has pressed TAB for) instead of app, for which hook was generated--program basename(/absolute/path/to/app)option, when--programoption is absent, because when completing for multiple apps the alias should always be presentUsage:
/path/to/app _completion -gmresults in hook generated forappalias and works even if you have 2appin different projects.I've also updated hook factory tests to check syntax for all
generateHookparameter combinations. Before it was checking syntax for case, when all parameters were given.Closes #44