Issue: #203 - Adding compatibility with polylang #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dkd-talwar Thank yo for your contribution I will review it and let you know. I apologize if I miss your other issue. Regards.!! |
|
At first sight I just noticed that you are repeating the same code. You can refactor the code and create a function on the |
|
Hey, Thanks for the review. I shall try that, and send another commit on this feature branch very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a small attempt to make the plugin compatible with Polylang by me and @IvayloIvanov
I know the code is not perfect. You could review and have a look and introduce possible changes.
May be, you could get in touch with Polylang Plugin author: Chouby as well.
After this commit,
Following issues stays unresolved (For Polylang Compatibility)
On Current Langauge ( Other than default language)
For example: Current Language is English, and default language is German,
For Non-authors, under comments, box after subscribing the comment, "subscribe_reloaded_subscribed_label, / subscribe_reloaded_waiting_label" doesn't appear.
Authors/ registered users see the manager_link with parameters (?srp or ?sre) in "subscribe_reloaded_subscribed_label, / subscribe_reloaded_waiting_label"
Please test and have a look.
Regards
Vineet Talwar