Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'filename' spelling in all tests #88

Merged
merged 1 commit into from
May 10, 2018
Merged

fix 'filename' spelling in all tests #88

merged 1 commit into from
May 10, 2018

Conversation

azhi
Copy link
Contributor

@azhi azhi commented Jan 16, 2018

Plug.Upload struct has a filename field, not file_name

Noticed it while working on #87: arc docs says store/1 accepts Plug.Upload or map with filename field, but in tests file_name is used.

@azhi
fix 'filename' spelling in all tests
3429c95 
Plug.Upload struct has a `filename` field, not `file_name`
pedep
pedep approved these changes Jan 16, 2018
View reviewed changes
Copy link

@pedep pedep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Since we don't have CI in arc_ecto repo, i have run the specs manually.
I can confirm they ran successfully on my machine 👍

@stavro stavro merged commit 8972a7d into stavro:master May 10, 2018
@azhi azhi deleted the fix-filename-in-tests branch May 10, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedep pedep pedep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azhi @pedep @stavro