nimbus-eth1: build flags for issues with secp256k1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
force-pushed
the
secp256k1-issues-with-x86
branch
from
deb8155
to
e225443
Compare
siddarthkay
force-pushed
the
secp256k1-issues-with-x86
branch
from
e225443
to
9cc9c8c
Compare
jakubgs
approved these changes
Oct 24, 2024
tersec
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deploying
nimbus-eth1failed on :bench-01.he-eu-hel1.nimbus.eth1bench-02.he-eu-hel1.nimbus.eth1with the issue described here ->
src/scalar_4x64_impl.h:361:5: error: ‘asm’ operand has impossible constraintsbitcoin-core/secp256k1#1623This PR provides a workaroud while this issue is fixed.
ref -> status-im/nimbus-eth2#6324 (comment)