Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli example usage #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YeungOnion
Copy link
Contributor

@YeungOnion YeungOnion commented Sep 24, 2024

figured text output would be quick for verifying implementations with external programs, will help with verifying the implementation of #287

EDIT
1Figured this is also an example of using the features, but not extending on top of the interface.

Footnotes

  1. removed commit messages from text

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.74%. Comparing base (e7a995e) to head (0fc0339).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/distribution/multinomial.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   93.70%   93.74%   +0.03%     
==========================================
  Files          53       53              
  Lines       11935    12007      +72     
==========================================
+ Hits        11184    11256      +72     
  Misses        751      751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lint: remove unused imports
(3 distributions) * (density evalution + sampling)

lint: run clippy

specify required features for random_clap

random_clap can pmf for multinomial

refactoring for multivariate densities

set some default parameters, on distn basis

fix: specify type sampled after merging statrs-dev#155

fix: sampling should use DistIter, but not collect it

chore: lint for reserve-after-new

doc: specify delimiter in help messages
@YeungOnion
Copy link
Contributor Author

Didn't even think about how dev-dependencies would affect the lockfile. The workflow for MSRV should generally avoid the dev dependencies. Will get back to this after the 0.18 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant