Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify date format for all contains_data_* fields #51

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Specify date format for all contains_data_* fields #51

merged 9 commits into from
Apr 26, 2024

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Apr 25, 2024 •
edited
Loading

  • This is the correct format since we don't define data periods with more granularity than a day.
  • The type for all fields now matches such that they agree with one another.

Ref: DPMETA-202

@mmwinther mmwinther requested review from BjornRoarJoneid and a team as code owners April 25, 2024 13:21
@github-actions github-actions bot added the json-schema Updates to the source models label Apr 25, 2024
@github-actions github-actions bot added the java Updates to the generated Java project label Apr 25, 2024
@mmwinther mmwinther changed the title Specify date-time format for contains_data_* fields Specify date format for all contains_data_* fields Apr 25, 2024
@github-actions github-actions bot added the python Updates to the generated Python project label Apr 25, 2024
Jorgen-5
Jorgen-5 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Jorgen-5 Jorgen-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mmwinther mmwinther merged commit b33bec7 into main Apr 26, 2024
4 of 5 checks passed
@mmwinther mmwinther deleted the correct-dataset-date-types branch April 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorgen-5 Jorgen-5 Jorgen-5 approved these changes

@BjornRoarJoneid BjornRoarJoneid Awaiting requested review from BjornRoarJoneid BjornRoarJoneid is a code owner

Assignees
No one assigned
Labels
java Updates to the generated Java project json-schema Updates to the source models python Updates to the generated Python project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmwinther @Jorgen-5