Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type for datasource #50

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Change type for datasource #50

merged 6 commits into from
Apr 23, 2024

Conversation

Jorgen-5
Copy link
Contributor

Changed datasource field type from language string type to string

@Jorgen-5 Jorgen-5 requested review from BjornRoarJoneid and a team as code owners April 23, 2024 12:49
@github-actions github-actions bot added enhancement New feature or request json-schema Updates to the source models python Updates to the generated Python project labels Apr 23, 2024
@github-actions github-actions bot added the java Updates to the generated Java project label Apr 23, 2024
mmwinther
mmwinther approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@Jorgen-5 Jorgen-5 merged commit bbb2726 into main Apr 23, 2024
4 of 5 checks passed
@Jorgen-5 Jorgen-5 deleted the feat/change-type-for-datasource branch April 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmwinther mmwinther mmwinther approved these changes

@BjornRoarJoneid BjornRoarJoneid Awaiting requested review from BjornRoarJoneid BjornRoarJoneid is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request java Updates to the generated Java project json-schema Updates to the source models python Updates to the generated Python project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorgen-5 @mmwinther