Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of owner field to string #48

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Mar 13, 2024

We save the section code to the model, so it's not necessary to record this in multiple languages.

This was backported and released in https://github.com/statisticsnorway/ssb-datadoc-model/releases/tag/python-v4.3.2 but also needs to be implemented for newer versions of the model.

@mmwinther mmwinther requested review from BjornRoarJoneid and a team as code owners March 13, 2024 15:13
@github-actions github-actions bot added json-schema Updates to the source models python Updates to the generated Python project java Updates to the generated Java project labels Mar 13, 2024
Copy link
Contributor

@Jorgen-5 Jorgen-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mmwinther mmwinther merged commit 87810f5 into main Mar 14, 2024
2 of 3 checks passed
@mmwinther mmwinther deleted the correct-owner-field-type branch March 14, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Updates to the generated Java project json-schema Updates to the source models python Updates to the generated Python project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants