Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Strongly-typed state value #4173

Closed
wants to merge 11 commits into from

Conversation

davidkpiano
Copy link
Member

Trying this again - supersedes #3940

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

⚠️ No Changeset found

Latest commit: a366225

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a366225:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Aug 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Comment on lines 1049 to 1051
invoke?: SingleOrArray<{
src: Literal | NonReducibleUnknown;
}>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the contextual type for invoke.src so it can be retained as a string literal

@Andarist
Copy link
Member

This will have to be redone on top of #4262 when we land it soon. I'll try to rebase this and test out the test cases that are here before landing TConfig

@Andarist
Copy link
Member

So far we can't infer what is needed for this feature and the current attempt at inferring this is in: #4262 . I think there is no reason to have this PR open until we manage to work out the inference part. Let's close it for now, for housekeeping purposes. It's referenced by that other PR so we can always track it back and reopen when/if needed.

@Andarist Andarist closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants