-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] Strongly-typed state value #4173
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a366225:
|
packages/core/src/types.ts
Outdated
invoke?: SingleOrArray<{ | ||
src: Literal | NonReducibleUnknown; | ||
}>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the contextual type for invoke.src
so it can be retained as a string literal
This will have to be redone on top of #4262 when we land it soon. I'll try to rebase this and test out the test cases that are here before landing |
So far we can't infer what is needed for this feature and the current attempt at inferring this is in: #4262 . I think there is no reason to have this PR open until we manage to work out the inference part. Let's close it for now, for housekeeping purposes. It's referenced by that other PR so we can always track it back and reopen when/if needed. |
Trying this again - supersedes #3940