Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Passing callback params to custom machine hooks #104

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

kevinmaes
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 12, 2022

STA-2252

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
blog ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 8:12PM (UTC)

@kevinmaes kevinmaes changed the title STA-2252-write-blog-post-about-passing-params Passing callback params to custom machine hooks Sep 13, 2022
@kevinmaes
Copy link
Contributor Author

Copy link
Contributor

@laurakalbag laurakalbag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great post, and I shall be linking to it liberally from the docs!

The “Request changes” is just in reference to the heading levels… I think they’re all off by one.

My other suggested changes are totally optional. It might look like a lot, but aside from a couple of typos, they’re mostly punctuation! Really depends on your preferences for commas.

@davidkpiano
Copy link
Member

Do you have a CodeSandbox for this? There might be a way to avoid using meta

kevinmaes and others added 7 commits September 15, 2022 21:18
… github.com:statelyai/blog into kevin/sta-2252-write-blog-post-about-passing-params
kevinmaes and others added 14 commits September 15, 2022 21:30
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
Co-authored-by: Laura Kalbag <[email protected]>
@kevinmaes
Copy link
Contributor Author

@laurakalbag Thanks so much for your thoughtful feedback. It is immensely helpful and I love your writing style! I've implemented all of your suggestions!

Now, I need to work on the code samples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants