Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switches from xid to ulid #411

Merged
merged 5 commits into from
Nov 1, 2023
Merged

switches from xid to ulid #411

merged 5 commits into from
Nov 1, 2023

Conversation

pastuxso
Copy link
Collaborator

@pastuxso pastuxso commented Oct 31, 2023 •
edited
Loading

Related: #408

@pastuxso pastuxso force-pushed the pastuxso/universal-id branch 14 times, most recently from eb98faa to e6494cf Compare October 31, 2023 22:19
@pastuxso pastuxso force-pushed the pastuxso/universal-id branch from e6494cf to ad0c83d Compare October 31, 2023 22:19
@pastuxso pastuxso marked this pull request as ready for review October 31, 2023 22:42
@pastuxso pastuxso linked an issue Nov 1, 2023 that may be closed by this pull request
Persistent id for every cell #408
Closed
10 tasks
@pastuxso pastuxso self-assigned this Nov 1, 2023
duvanmonsa
duvanmonsa approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@duvanmonsa duvanmonsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests locally and it it seems to work correctly. Also the code is looking good.

sourishkrout
sourishkrout requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Without wanting to be nit-picky, we've tried hard to avoid catch all "utils" - probably haven't mentioned that to you before @pastuxso.

Perhaps we can just rename the package ulid or something of that sort. Let's see how much longer we can get away without utils.

@pastuxso pastuxso force-pushed the pastuxso/universal-id branch from f0d5e01 to 4f8b0c1 Compare November 1, 2023 19:48
sourishkrout
sourishkrout approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 @pastuxso let's merge!

@pastuxso pastuxso merged commit a65ce24 into v2 Nov 1, 2023
4 checks passed
@pastuxso pastuxso deleted the pastuxso/universal-id branch November 1, 2023 20:49
@pastuxso pastuxso mentioned this pull request Nov 3, 2023
Closed
10 tasks
pastuxso added a commit that referenced this pull request Nov 3, 2023
@pastuxso
switches from xid to ulid (#411)
bbe7ece
pastuxso added a commit that referenced this pull request Nov 7, 2023
@pastuxso
switches from xid to ulid (#411)
e5da8eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duvanmonsa duvanmonsa duvanmonsa approved these changes

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees

@pastuxso pastuxso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent id for every cell
3 participants
@pastuxso @sourishkrout @duvanmonsa