Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support to handle skipPrompts from MD files in the cli #410

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

pastuxso
Copy link
Collaborator

@pastuxso pastuxso commented Oct 25, 2023

Fix: #407
Closes: #405

Smoke tests:

  1. Switch to the branch delta/allow-skipprompts

  2. Run: runme run make-build.

  3. Execute: runme run make-test.

  4. Run: ./runme run skip-prompts-sample.

  5. Update the VS Code extension to point to the generated binary.

    Example:

    "runme.server.binaryPath": "/home/cristian/go/src/github.com/stateful/runme/runme"

  6. Test the execution of the markdown files.

@pastuxso pastuxso force-pushed the delta/allow-skipprompts branch from ba354eb to c53448c Compare October 25, 2023 14:47
@pastuxso pastuxso marked this pull request as draft October 25, 2023 17:24
@pastuxso pastuxso marked this pull request as ready for review October 26, 2023 01:28
@pastuxso pastuxso force-pushed the delta/allow-skipprompts branch from 9734601 to 0608eb9 Compare October 26, 2023 02:14
@pastuxso pastuxso force-pushed the delta/allow-skipprompts branch from 0608eb9 to 0d2453e Compare October 26, 2023 02:18
Copy link
Contributor

@degrammer degrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me, tests are failing locally in my machine. It seems related to my OS setup

@sourishkrout sourishkrout removed their request for review October 27, 2023 15:20
@sourishkrout
Copy link
Member

@pastuxso two reviews for this level of complexity are sufficient. Let's merge 👍 .

@pastuxso pastuxso merged commit d471012 into main Oct 27, 2023
4 checks passed
@pastuxso pastuxso deleted the delta/allow-skipprompts branch October 27, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runme run --all if a category is not provided Respect skipPrompts in frontmatter in CLI
4 participants