Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.22 #35

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Use Go 1.22 #35

merged 1 commit into from
Apr 8, 2024

Conversation

tamalsaha
Copy link
Member

Signed-off-by: Tamal Saha [email protected]

/cherry-pick

Signed-off-by: Tamal Saha <[email protected]>
Copy link

gitguardian bot commented Apr 8, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8646284 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/testdata/server_key.pem View secret
8646284 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8646289 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/testdata/client_key.pem View secret
8646289 Triggered RSA Private Key 380a8d9 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
10001632 Triggered Generic Private Key 380a8d9 vendor/github.com/google/s2a-go/testdata/mds_client_key.pem View secret
10001633 Triggered Generic Private Key 380a8d9 vendor/github.com/google/s2a-go/testdata/mds_server_key.pem View secret
10001634 Triggered Generic Private Key 380a8d9 vendor/github.com/google/s2a-go/testdata/self_signed_key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tamalsaha tamalsaha added the automerge Kodiak will auto merge PRs that have this label label Apr 8, 2024
@kodiakhq kodiakhq bot merged commit a5db6f5 into master Apr 8, 2024
5 checks passed
@kodiakhq kodiakhq bot deleted the go122 branch April 8, 2024 13:57
1gtm pushed a commit that referenced this pull request Apr 8, 2024
/cherry-pick

Signed-off-by: Tamal Saha <[email protected]>
kodiakhq bot pushed a commit that referenced this pull request Apr 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
/cherry-pick

Signed-off-by: Tamal Saha <[email protected]>
Co-authored-by: Tamal Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Kodiak will auto merge PRs that have this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant