Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix .travis.rosinstall.kinetic (use rtm-ros-robotics directory) #567

Closed
wants to merge 1 commit into from
Closed

fix .travis.rosinstall.kinetic (use rtm-ros-robotics directory) #567

wants to merge 1 commit into from

Conversation

Naoki-Hiraoka
Copy link
Contributor

#566

  • fix .travis.rosinstall.kinetic to put rtmros_gazebo under the rtm-ros-robotics directory

@pazeshun pazeshun self-requested a review April 9, 2020 04:50
pazeshun
pazeshun requested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@pazeshun pazeshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to use .travis.rosinstall.kinetic in workspace creation on your local PC as well as on travis, don't you?
If so, please update README to use .travis.rosinstall.${ROS_DISTRO}.

@Naoki-Hiraoka
Copy link
Contributor Author

I will update README to use .travis.rosinstall.${ROS_DISTRO}.

Since the last update of README.md is 5 years ago and the sample gazebo programs do not work in kinetic now, it will take some time.

@Naoki-Hiraoka Naoki-Hiraoka mentioned this pull request Apr 13, 2020
Merged
@Naoki-Hiraoka
Copy link
Contributor Author

Naoki-Hiraoka commented Apr 13, 2020 •
edited
Loading

This PR is include in #571 .
The comment #567 (review) is dealt with in #569

@Naoki-Hiraoka Naoki-Hiraoka mentioned this pull request Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazeshun pazeshun pazeshun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naoki-Hiraoka @pazeshun