Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relation summary #911

Open
wants to merge 1 commit into
base: ohad/relationeval
Choose a base branch
from
Open

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Nov 28, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (b4fefbf) to head (4816a4a).

Files with missing lines Patch % Lines
...rover/src/constraint_framework/relation_tracker.rs 0.00% 29 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           ohad/relationeval     #911      +/-   ##
=====================================================
- Coverage              90.96%   90.67%   -0.30%     
=====================================================
  Files                     94       94              
  Lines                  13486    13313     -173     
  Branches               13486    13313     -173     
=====================================================
- Hits                   12268    12071     -197     
- Misses                  1107     1129      +22     
- Partials                 111      113       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 4816a4a Previous: cd8b37b Ratio
iffts/simd ifft/22 13121331 ns/iter (± 699580) 6306399 ns/iter (± 210024) 2.08
iffts/simd ifft/26 274786573 ns/iter (± 5080546) 136655216 ns/iter (± 2242165) 2.01
iffts/simd ifft/27 639337761 ns/iter (± 25581163) 312588285 ns/iter (± 9816879) 2.05
iffts/simd ifft/28 1322904871 ns/iter (± 53064367) 643771030 ns/iter (± 19147376) 2.05
merkle throughput/simd merkle 30186854 ns/iter (± 1107196) 13712527 ns/iter (± 579195) 2.20

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants