-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant collect
in framework.
#896
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)
5a1d139
to
4083523
Compare
32d5aae
to
3497948
Compare
3497948
to
d1e2104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: d1e2104 | Previous: f6214d1 | Ratio |
---|---|---|---|
merkle throughput/simd merkle |
31774754 ns/iter (± 725842 ) |
14690867 ns/iter (± 434150 ) |
2.16 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #896 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.01%
==========================================
Files 93 93
Lines 13097 13092 -5
Branches 13097 13092 -5
==========================================
- Hits 12043 12038 -5
Misses 939 939
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Merge activity
|
No description provided.