Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant collect in framework. #896

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Nov 19, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Alon-Ti commented Nov 19, 2024

@Alon-Ti Alon-Ti marked this pull request as ready for review November 19, 2024 14:45
Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

@Alon-Ti Alon-Ti changed the base branch from alont/generalize-gen-interaction-trace3 to graphite-base/896 November 23, 2024 04:20
@Alon-Ti Alon-Ti force-pushed the alont/generalize-gen-interaction-trace4 branch from 32d5aae to 3497948 Compare November 23, 2024 04:20
@Alon-Ti Alon-Ti changed the base branch from graphite-base/896 to dev November 23, 2024 04:21
@Alon-Ti Alon-Ti force-pushed the alont/generalize-gen-interaction-trace4 branch from 3497948 to d1e2104 Compare November 23, 2024 04:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: d1e2104 Previous: f6214d1 Ratio
merkle throughput/simd merkle 31774754 ns/iter (± 725842) 14690867 ns/iter (± 434150) 2.16

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (4083523) to head (d1e2104).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.01%     
==========================================
  Files          93       93              
  Lines       13097    13092       -5     
  Branches    13097    13092       -5     
==========================================
- Hits        12043    12038       -5     
  Misses        939      939              
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Alon-Ti Alon-Ti merged commit 56a6a61 into dev Nov 23, 2024
17 of 19 checks passed
Copy link
Contributor Author

Alon-Ti commented Nov 23, 2024

Merge activity

  • Nov 23, 6:14 PM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants