Skip to content

Commit

Permalink
Rename Constant trace -> Preprocessed trace. (#881)
Browse files Browse the repository at this point in the history
  • Loading branch information
ilyalesokhin-starkware authored Nov 12, 2024
1 parent b801320 commit 64270dc
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions crates/prover/src/examples/blake/air.rs
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,9 @@ where
let channel = &mut MC::C::default();
let commitment_scheme = &mut CommitmentSchemeProver::new(config, &twiddles);

// Constant trace.
// Preprocessed trace.
// TODO(ShaharS): share is_first column between components when constant columns support this.
let span = span!(Level::INFO, "Constant Trace").entered();
let span = span!(Level::INFO, "Preprocessed Trace").entered();
let mut tree_builder = commitment_scheme.tree_builder();
tree_builder.extend_evals(
chain![
Expand Down Expand Up @@ -472,7 +472,7 @@ pub fn verify_blake<MC: MerkleChannel>(

let log_sizes = stmt0.log_sizes();

// Constant trace.
// Preprocessed trace.
commitment_scheme.commit(stark_proof.commitments[0], &log_sizes[0], channel);

// Trace.
Expand Down
8 changes: 4 additions & 4 deletions crates/prover/src/examples/blake/xor_table/gen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ pub fn generate_trace<const ELEM_BITS: u32, const EXPAND_BITS: u32>(
}

/// Generates the interaction trace for the xor table.
/// Returns the interaction trace, the constant trace, and the claimed sum.
/// Returns the interaction trace, the Preprocessed trace, and the claimed sum.
#[allow(clippy::type_complexity)]
pub fn generate_interaction_trace<const ELEM_BITS: u32, const EXPAND_BITS: u32>(
lookup_data: XorTableLookupData<ELEM_BITS, EXPAND_BITS>,
Expand Down Expand Up @@ -135,13 +135,13 @@ pub fn generate_interaction_trace<const ELEM_BITS: u32, const EXPAND_BITS: u32>(
logup_gen.finalize_last()
}

/// Generates the constant trace for the xor table.
/// Returns the constant trace, the constant trace, and the claimed sum.
/// Generates the Preprocessed trace for the xor table.
/// Returns the Preprocessed trace, the Preprocessed trace, and the claimed sum.
#[allow(clippy::type_complexity)]
pub fn generate_constant_trace<const ELEM_BITS: u32, const EXPAND_BITS: u32>(
) -> ColumnVec<CircleEvaluation<SimdBackend, BaseField, BitReversedOrder>> {
let limb_bits = limb_bits::<ELEM_BITS, EXPAND_BITS>();
let _span = span!(Level::INFO, "Xor constant trace").entered();
let _span = span!(Level::INFO, "Xor Preprocessed trace").entered();

// Generate the constant columns. In reality, these should be generated before the proof
// even began.
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/examples/plonk/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ pub fn prove_fibonacci_plonk(
let commitment_scheme =
&mut CommitmentSchemeProver::<_, Blake2sMerkleChannel>::new(config, &twiddles);

// Constant trace.
// Preprocessed trace.
let span = span!(Level::INFO, "Constant").entered();
let mut tree_builder = commitment_scheme.tree_builder();
let is_first = gen_is_first(log_n_rows);
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/examples/poseidon/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ pub fn prove_poseidon(
let commitment_scheme =
&mut CommitmentSchemeProver::<_, Blake2sMerkleChannel>::new(config, &twiddles);

// Constant trace.
// Preprocessed trace.
let span = span!(Level::INFO, "Constant").entered();
let mut tree_builder = commitment_scheme.tree_builder();
let constant_trace = vec![gen_is_first(log_n_rows)];
Expand Down
2 changes: 1 addition & 1 deletion crates/prover/src/examples/state_machine/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub fn prove_state_machine(
let commitment_scheme =
&mut CommitmentSchemeProver::<_, Blake2sMerkleChannel>::new(config, &twiddles);

// Constant trace.
// Preprocessed trace.
let mut tree_builder = commitment_scheme.tree_builder();
tree_builder.extend_evals(vec![
gen_is_first(x_axis_log_rows),
Expand Down

1 comment on commit 64270dc

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 64270dc Previous: f6214d1 Ratio
merkle throughput/simd merkle 30004347 ns/iter (± 521890) 14690867 ns/iter (± 434150) 2.04

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Please sign in to comment.