Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_api): entry points by type field of sierra contact #2294

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.451 ms 30.499 ms 30.550 ms]
change: [-3.0254% -2.7135% -2.4168%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.60%. Comparing base (e3165c4) to head (378185a).
Report is 602 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/rpc_transaction.rs 50.00% 7 Missing ⚠️
crates/papyrus_protobuf/src/converters/class.rs 0.00% 5 Missing ⚠️
...s/papyrus_storage/src/serialization/serializers.rs 0.00% 0 Missing and 1 partial ⚠️
crates/starknet_client/src/reader/objects/state.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2294       +/-   ##
===========================================
+ Coverage   40.10%   57.60%   +17.49%     
===========================================
  Files          26      160      +134     
  Lines        1895    23437    +21542     
  Branches     1895    23437    +21542     
===========================================
+ Hits          760    13500    +12740     
- Misses       1100     8451     +7351     
- Partials       35     1486     +1451     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the 11-26-refactor_starknet_api_entry_points_by_type_field_of_sierra_contact branch from dc6c2e4 to a511d59 Compare November 27, 2024 07:48
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [31.813 ms 31.873 ms 31.935 ms]
change: [+3.9138% +4.1921% +4.4887%] (p = 0.00 < 0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/refactor_sierra_contract_class to graphite-base/2294 November 27, 2024 09:42
@AvivYossef-starkware AvivYossef-starkware force-pushed the 11-26-refactor_starknet_api_entry_points_by_type_field_of_sierra_contact branch from a511d59 to 607c640 Compare November 27, 2024 09:42
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2294 to main November 27, 2024 09:43
@AvivYossef-starkware AvivYossef-starkware force-pushed the 11-26-refactor_starknet_api_entry_points_by_type_field_of_sierra_contact branch from 607c640 to 378185a Compare November 27, 2024 09:43
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [31.463 ms 31.573 ms 31.715 ms]
change: [+3.3951% +4.2665% +4.9775%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 2a97de2 into main Nov 27, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants