Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): allow a streamed proposal channel on top of existing #2262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guy-starkware
Copy link
Contributor

This is part of a series of PRs to integrate streaming of consensus proposals.
It adds the streaming channels but does not connect them to block building or validation, yet.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.024 ms 34.482 ms 35.018 ms]
change: [+1.1167% +2.4665% +4.0611%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
11 (11.00%) high severe

@guy-starkware guy-starkware force-pushed the guyn/streams/add_proposal_channel branch from cf16406 to 46b7c49 Compare November 25, 2024 12:32
@guy-starkware guy-starkware changed the title feat(consensus): allow a streamed proposal channel on top of existing one feat(consensus): allow a streamed proposal channel on top of existing Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 61.07784% with 65 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (e3165c4) to head (e7feca7).
Report is 576 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_protobuf/src/consensus.rs 32.65% 32 Missing and 1 partial ⚠️
crates/starknet_api/src/transaction.rs 39.13% 14 Missing ⚠️
crates/papyrus_node/src/run.rs 0.00% 13 Missing ⚠️
...sequencing/papyrus_consensus/src/stream_handler.rs 93.75% 0 Missing and 2 partials ⚠️
...nsus_orchestrator/src/papyrus_consensus_context.rs 86.66% 2 Missing ⚠️
...rates/papyrus_protobuf/src/converters/consensus.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2262       +/-   ##
===========================================
+ Coverage   40.10%   77.01%   +36.90%     
===========================================
  Files          26      386      +360     
  Lines        1895    40548    +38653     
  Branches     1895    40548    +38653     
===========================================
+ Hits          760    31228    +30468     
- Misses       1100     7022     +5922     
- Partials       35     2298     +2263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@guy-starkware guy-starkware force-pushed the guyn/streams/add_proposal_channel branch 2 times, most recently from 20624b9 to e7feca7 Compare November 25, 2024 15:23
@guy-starkware guy-starkware force-pushed the guyn/streams/add_proposal_channel branch from e7feca7 to 53447b3 Compare November 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants