LS: Send project model updates through channel

[piotmag769]

No description provided.

[reviewable-StarkWare]

This change is 

[Draggu]

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @Arcticae, @integraledelebesgue, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 130 at r1 (raw file):

        if !self.is_silent {
            self.notifier.notify::<ScarbResolvingFinish>(());
            self.notifier.notify::<ScarbMetadataFailed>(());

Why? You don't even check if it was successful or not.

---

crates/cairo-lang-language-server/src/project/mod.rs line 26 at r1 (raw file):

mod unmanaged_core_crate;

pub struct ProjectController {

Move Notifier and ScarbToolchain to the controller state to make it consistent with other controllers

---

crates/cairo-lang-language-server/src/project/mod.rs line 88 at r1 (raw file):

        };

        // TODO: do sth smart here

What is "sth smart"?

[piotmag769]

Reviewed 2 of 3 files at r2.
Reviewable status: 2 of 6 files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @integraledelebesgue, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/src/project/mod.rs line 26 at r1 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

Move Notifier and ScarbToolchain to the controller state to make it consistent with other controllers

If it will be used in more than one function I will

---

crates/cairo-lang-language-server/src/project/mod.rs line 88 at r1 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

What is "sth smart"?

Done.

---

crates/cairo-lang-language-server/src/toolchain/scarb.rs line 130 at r1 (raw file):

Previously, Draggu (Piotr Figiela) wrote…

Why? You don't even check if it was successful or not.

Done.