-
Notifications
You must be signed in to change notification settings - Fork 108
feat(native_blockifier): allow overriding max invoke steps #2110
feat(native_blockifier): allow overriding max invoke steps #2110
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-v0.13.1-kakarot #2110 +/- ##
========================================================
+ Coverage 70.93% 70.97% +0.03%
========================================================
Files 59 59
Lines 8114 8103 -11
Branches 8114 8103 -11
========================================================
- Hits 5756 5751 -5
+ Misses 1946 1940 -6
Partials 412 412 ☔ View full report in Codecov by Sentry. |
90d3835
to
404ee63
Compare
Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
404ee63
to
72366d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @OriStarkware and @Yoni-Starkware)
Cargo.toml
line 61 at r2 (raw file):
rust-2018-idioms = "deny" unused = { level = "deny", priority = -1 } warnings = "deny"
new clippy errors from rustc v1.80
Code quote:
unused = { level = "deny", priority = -1 }
warnings = "deny"
crates/blockifier/src/fee/actual_cost.rs
line 192 at r2 (raw file):
// Add reverted steps to actual_resources' n_steps for correct fee charge. *actual_resources.0.get_mut(&abi_constants::N_STEPS_RESOURCE.to_string()).unwrap() +=
new clippy errors from rustc v1.80
Code quote:
(&abi_constants::N_STEPS_RESOURCE.to_string())
crates/blockifier/src/state/cached_state_test.rs
line 393 at r4 (raw file):
// Assert local cache is initialized empty even if global cache is not empty. assert!(!state.class_hash_to_class.contains_key(&class_hash));
new clippy errors from rustc v1.80
Code quote:
!state.class_hash_to_class.contains_key(&class_hash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 4 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @OriStarkware)
This change is