Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

feat(native_blockifier): allow overriding max invoke steps #2110

Merged

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 12, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (4fd7164) to head (72366d6).

Files Patch % Lines
crates/native_blockifier/src/py_block_executor.rs 0.00% 6 Missing ⚠️
crates/native_blockifier/src/py_validator.rs 0.00% 6 Missing ⚠️
crates/native_blockifier/src/py_utils.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           main-v0.13.1-kakarot    #2110      +/-   ##
========================================================
+ Coverage                 70.93%   70.97%   +0.03%     
========================================================
  Files                        59       59              
  Lines                      8114     8103      -11     
  Branches                   8114     8103      -11     
========================================================
- Hits                       5756     5751       -5     
+ Misses                     1946     1940       -6     
  Partials                    412      412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the dori/allow-invoke-max-steps-override branch from 90d3835 to 404ee63 Compare August 12, 2024 13:08
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @OriStarkware and @Yoni-Starkware)


Cargo.toml line 61 at r2 (raw file):

rust-2018-idioms = "deny"
unused = { level = "deny", priority = -1 }
warnings = "deny"

new clippy errors from rustc v1.80

Code quote:

unused = { level = "deny", priority = -1 }
warnings = "deny"

crates/blockifier/src/fee/actual_cost.rs line 192 at r2 (raw file):

        // Add reverted steps to actual_resources' n_steps for correct fee charge.
        *actual_resources.0.get_mut(&abi_constants::N_STEPS_RESOURCE.to_string()).unwrap() +=

new clippy errors from rustc v1.80

Code quote:

(&abi_constants::N_STEPS_RESOURCE.to_string())

crates/blockifier/src/state/cached_state_test.rs line 393 at r4 (raw file):

    // Assert local cache is initialized empty even if global cache is not empty.
    assert!(!state.class_hash_to_class.contains_key(&class_hash));

new clippy errors from rustc v1.80

Code quote:

!state.class_hash_to_class.contains_key(&class_hash)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 4 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @OriStarkware)

@dorimedini-starkware dorimedini-starkware merged commit 3303b69 into main-v0.13.1-kakarot Aug 12, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants