-
Notifications
You must be signed in to change notification settings - Fork 108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
c6d149a
to
c9d40d3
Compare
79d8089
to
9c696b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier/src/transaction/error_format_test.rs
line 45 at r2 (raw file):
#[test] fn test_invalid_nounce_format() {
typo
Suggestion:
invalid_nonce_format
The base branch was changed.
9c696b8
to
2b23e50
Compare
2b23e50
to
2b421bb
Compare
0662936
to
48795ed
Compare
2b421bb
to
5c29d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
48795ed
to
20207a1
Compare
5c29d85
to
b714a3d
Compare
The base branch was changed.
b714a3d
to
d57f8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
commit-id:85a8a843
The merge-base changed after approval.
d57f8db
to
d1ed414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
commit-id:85a8a843
Stack:
This change is