This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
feat(ContractClass): add deserialization
#1937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
changed the title
ContractClassContractClass): add deserialization
tdelabro
suggested changes
May 31, 2024
Comment on lines
+169
to
+185
| impl<'de> Deserialize<'de> for ContractClassV1 { | ||
| fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> | ||
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| // Deserialize into a JSON value | ||
| let json_value: serde_json::Value = Deserialize::deserialize(deserializer)?; | ||
|
|
||
| // Convert into a JSON string | ||
| let json_string = serde_json::to_string(&json_value) | ||
| .map_err(|err| DeserializationError::custom(err.to_string()))?; | ||
|
|
||
| // Use try_from_json_string to deserialize into ContractClassV1 | ||
| ContractClassV1::try_from_json_string(&json_string) | ||
| .map_err(|err| DeserializationError::custom(err.to_string())) | ||
| } | ||
| } |
There was a problem hiding this comment.
The true issue here is that cairo_vm::program doesn't implement serde.
So we have to go through all this. It's inefficient.
I opened an issue on the cairo-vm: lambdaclass/cairo-vm#1660
I think you should push this one first, and then update in the blockifier once it is merged
There was a problem hiding this comment.
This issue looks lambdaclass/cairo-vm#1660 like it'll take a long time to be implemented and merged, how can we not be blocked by it?
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds deserialization support for the
ContractClassstruct. The changes include implementing theDeserializetrait forContractClassV1and updating the unit tests to verify the correct deserialization of bothContractClassV0andContractClassV1.Implementation of
DeserializeforContractClassV1:Deserializetrait has been implemented forContractClassV1to support deserialization from JSON.try_from_json_stringmethod to deserialize into aContractClassV1object.This change is