Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluentd arm image for nerdctl #4

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Jul 17, 2024

What:
Add fluentd arm image for nerdctl

Why:
This image was used in nerdctl in containerd/nerdctl#3045

@yankay
Copy link
Contributor Author

yankay commented Jul 17, 2024

HI @ktock, would you please help to review it? :-)

@AkihiroSuda
Copy link

ping @ktock

Comment on lines 64 to 65
Image("fluent/fluentd:v1.14-1", ["tini" "--" "/bin/entrypoint.sh"]),
Image("fluent/fluentd:v1.14-arm64-debian", ["tini" "--" "/bin/entrypoint.sh"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delimiters are needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktock
It has been changed

@yankay yankay force-pushed the add-fluentd branch 3 times, most recently from 1108d34 to 0bb176d Compare August 1, 2024 12:26
Signed-off-by: Kay Yan <[email protected]>
@yankay yankay requested a review from ktock August 1, 2024 12:40
Copy link
Contributor

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ktock ktock merged commit 7a6948d into stargz-containers:master Aug 1, 2024
1 check passed
@yankay
Copy link
Contributor Author

yankay commented Aug 5, 2024

The job failed with 403 Forbidden: https://github.com/stargz-containers/image-ci/actions/runs/10202170474/job/28225691301#step:6:334

It's strange 🤔

@yankay
Copy link
Contributor Author

yankay commented Aug 6, 2024

The job failed with 403 Forbidden: https://github.com/stargz-containers/image-ci/actions/runs/10202170474/job/28225691301#step:6:334

It's strange 🤔

HI @ktock

The image push failed by 403 Forbidden, It may fixed by:

image

Ref: docker/build-push-action#687 (comment)

@ktock
Copy link
Contributor

ktock commented Aug 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants