Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for maxium ANN limit #1808

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Add validation for maxium ANN limit #1808

merged 5 commits into from
Jan 3, 2025

Conversation

Hazel-Datastax
Copy link
Contributor

What this PR does:
Add validation for maxium ANN limit

Which issue(s) this PR fixes:
Fixes #1707

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Hazel-Datastax Hazel-Datastax marked this pull request as ready for review December 23, 2024 18:31
@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner December 23, 2024 18:31
tatu-at-datastax
tatu-at-datastax approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hazel-Datastax Hazel-Datastax merged commit be4ca1c into main Jan 3, 2025
3 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/ann_limit_validation branch January 3, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation for maxium ANN limit
2 participants
@Hazel-Datastax @tatu-at-datastax