Minor clean up on #1698 fix based on code review comments #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Hazel-Datastax
approved these changes
Dec 20, 2024
| @@ -45,7 +44,7 @@ public Optional<ColumnsDescContainer> schemaDescription() { | |||
| return Optional.empty(); | |||
| } | |||
| var apiColumns = schemaObject.apiTableDef().primaryKeys(); | |||
| var unsupported = apiColumns.filterBySupport(ApiSupportDef::isUnsupportedInsert); | |||
| var unsupported = apiColumns.filterBySupport(x -> !x.insert()); | |||
There was a problem hiding this comment.
Not sure I fully understand why Matcher cannot be used in this case. Aaron has the negation example in WriteableTableRowBuilder (sorry, there are so many NO_MATCHES examples and I just randomly picked one previously.)
I tried ApiSupportDef.Matcher.NO_MATCHES.withInsert(false) here and it could pass the test insertValidVectorKey you added in the previous PR. So I think it works? I don't mean we always need to have the same way, just curious.
There was a problem hiding this comment.
To me this way seems bit simpler than building and using a Matcher, that's all. I am sure Matcher could be used, and would make sense for more complex cases.
So maybe just matter of preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Cleans up PR #1798 (for #1698) to simplify code, avoid adding new method.
Based on PR review comments added post-merge.
Which issue(s) this PR fixes:
N/A
Checklist