Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete reflection probes for the native new pipeline #167

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

GengineJS
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -35936,9 +35936,9 @@
              *
              * @param copyPairs @en Array of copy source and target @zh 拷贝来源与目标的数组
              */
             addCopyPass(copyPairs: CopyPair[]): void;
-            addBuiltinReflectionProbePass(width: number, height: number): void;
+            addBuiltinReflectionProbePass(width: number, height: number, camera: renderer.scene.Camera): void;
         }
         /**
          * @beta Feature is under development
          * @en Render subpass

@star-e star-e merged commit f565651 into star-e:v3.8.1-pipeline Aug 30, 2023
17 of 23 checks passed
@github-actions
Copy link

@GengineJS ❗ There was an error during the execution of the tasks. Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants