-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weāll occasionally send you account related emails.
Already on GitHub? Sign in to your account
š„DO NOT MERGEš„ ā add new TPC alignment, hit errors and slewing corrections for 2024 #702
base: main
Are you sure you want to change the base?
Changes from 42 commits
f24b000
b9352bd
9aae93c
d152e4f
24316ac
921b24e
1fe7ee9
282c28f
5b2ecc5
2be2cf8
d04a560
701026a
ae31ad3
550ae69
5c66e08
10bda9e
ea24401
8828f60
b6046fe
12fa9ff
8496cf4
1088b8f
eee260b
85e5ff6
470757a
a3bfe16
cfd375d
883bc88
92933ae
65ad613
df6a290
d2d77f6
03176b3
d21c128
15106c7
1d9e062
2f52e6c
cac6321
69abeeb
46576ea
bbaaf85
66b02fe
709d840
987442b
75eaec9
36ca1de
d919c1d
77be6db
8acdf8e
dc447f4
8bc3333
8a19542
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1093,6 +1093,7 @@ Bfc_st BFC[] = { // standard chains | |
{"NoLocalCintDb","" ,"","" ,"","","Switch off local Cint Db",kFALSE}, | ||
{"NoMySQLDb" ,"" ,"","" ,"","","Switch off MySQL Db",kFALSE}, | ||
{"NoCintCalDb" ,"" ,"","NoLocalCintDb" ,"","","Switch off local Cint Db",kFALSE}, | ||
{"NoTFGLDbTag" ,"" ,"","" ,"","","Switch off TFG specific Db tag",kFALSE}, | ||
{"dbSnapshot" ,"" ,"","" ,"","","Create?use dbSnapshot",kFALSE}, | ||
{"NoEvent" ,"" ,"","-event,-analysis" ,"","","Switch Off StEvent and StAnalysis Makers",kFALSE}, | ||
{"MakeDoc" ,"" ,"","" ,"","","Make HTML documentation for the given Chain",kFALSE}, | ||
|
@@ -1134,8 +1135,11 @@ Bfc_st BFC[] = { // standard chains | |
, "... Corr4+SCEbyE,OGridLeak3D,OSpaceZ2...",kFALSE}, | ||
{"CorrX" ,"" ,"","ExB,OShortR,OBmap,OPr13,OIFC,OSectorAlign,NewTpcAlignment" | ||
",-AlignSectors,-OBmap2D,-OClock,-OTwist" ,"","","New Tpc Alignment",kFALSE}, | ||
{"CorrY" ,"" ,"","ExB,OShortR,OBmap,OPr40,OIFC,OSectorAlign,NewTpcAlignment,OSpaceZ2,OGridLeakFull" | ||
{"CorrY" ,"" ,"","ExB,OShortR,OBmap,OPr40,-OPr13,OIFC,OSectorAlign,NewTpcAlignment,OSpaceZ2,OGridLeakFull" | ||
",-AlignSectors,-OBmap2D,-OClock,-OTwist" ,"","","New Tpc Alignment",kFALSE}, | ||
{"Alignment2024","" ,"","NewTpcAlignment" ,"","","Turn on Alignment 2024",kFALSE}, | ||
{"CorrZ","" ,"","Alignment2024,TFGdbOpt,-CorrY,-CorrX,ExB,OShortR,OBmap,OPr40,-Opr13,OIFC,OSpaceZ2" | ||
",OGridLeakFull,-OBmap2D,-OClock,-OTwist,-OSectorAlign" ,"","","Tpc Alignment 2024",kFALSE}, | ||
{"ExB" ,"" ,"","","" ,"","Activate ExB correction",kFALSE}, | ||
{"EB1" ,"" ,"","","" ,"","Force ExB configuration 1",kFALSE}, | ||
{"EB2" ,"" ,"","","" ,"","Force ExB configuration 2",kFALSE}, | ||
|
@@ -1192,6 +1196,7 @@ Bfc_st BFC[] = { // standard chains | |
{"useLDV" ,"" ,"","","" ,"","... uses laserDV database flavor",kFALSE}, | ||
{"useCDV" ,"" ,"","","" ,"","... uses ofl database flavor",kFALSE}, | ||
{"useNewLDV" ,"" ,"","","" ,"","... uses ofl database flavor",kFALSE}, | ||
{"TFGdbOpt" ,"" ,"","","" ,"","... uses TFG database flavor for alignemnt tables",kFALSE}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this imply that TFG now has distinct database entries in addition to distinct software? It is unclear to me why we need this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see this note in the documentation: If this is the purpose, then we should not be using "TFG" in the chain option, nor in the database entries' flavors (production should never depend on anything labeled as developmental). Something more similar/related to "Alignment2024" is more appropriate. And if this is only meant to pair with the new There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ignored |
||
{"------------","-----------","-----------","------------------------------------------","","","",kFALSE}, | ||
{"Tables ","-----------","-----------","------------------------------------------","","","",kFALSE}, | ||
{"------------","-----------","-----------","------------------------------------------","","","",kFALSE}, | ||
|
@@ -1725,7 +1730,7 @@ Bfc_st BFC[] = { // standard chains | |
|
||
|
||
// Sti/Stv chains | ||
{"Sti" ,"Sti","","StiLib,StiLibs,SCL,StEvent,StDbT,TpcIT,compend,sim_T,tbutil","StiMaker" | ||
{"Sti" ,"Sti","","StiLib,StiLibs,SCL,StEvent,dbutil,StDbT,TpcIT,compend,sim_T,tbutil","StiMaker" | ||
, "StEventUtilities,StiUtilities,StiMaker","Sti tracker",kFALSE}, | ||
{"StiCA" ,"Sti","","Sti","StiMaker","TPCCATracker" ,"StiCA tracker",kFALSE}, | ||
{"StiCAPerf","","","","", "TPCCATrackerPerformance", "CA Performance",kFALSE}, | ||
|
@@ -1784,7 +1789,7 @@ Bfc_st BFC[] = { // standard chains | |
{"ETofQa", "", "ETofChain", "db, ETofUtil, muDst", "StETofQAMaker", "StETofQAMaker", | ||
"ETOF QA maker",kFALSE}, | ||
|
||
{"ETofA", "", "","etofdat,ETofCalib,etofhit,ETofMatch","","... ETOF chain options for data", kFALSE}, | ||
{"ETofA", "", "","etofdat,ETofCalib,etofhit,ETofMatch","","","... ETOF chain options for data", kFALSE}, | ||
|
||
|
||
// the below needs to be done earlier to save time - leaving here for documentation purposes as two | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
#include "StTpcLocalSectorAlignedCoordinate.hh" | ||
#include "StTpcLocalSectorDirection.hh" | ||
#include "StTpcLocalSectorCoordinate.hh" | ||
#include "Stiostream.h" | ||
fisyak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
//________________________________________________________________________________ | ||
StTpcLocalCoordinate::StTpcLocalCoordinate(double x, double y, double z) : StTpcCoordinate(x,y,z,0,0) {} | ||
//________________________________________________________________________________ | ||
|
@@ -21,6 +22,8 @@ ostream& operator<<(ostream& os, const StTpcCoordinate& a) { | |
return os << OS; | ||
} | ||
//________________________________________________________________________________ | ||
void StTpcCoordinate::Print(Option_t *option) const {cout << *this << endl;} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the use of cout and endl prompt the inclusion of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ignored |
||
//________________________________________________________________________________ | ||
ostream& operator<<(ostream& os, const StTpcLocalDirection& a) { | ||
return os << "TPC_Local Direction( (" << OS; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can introduce a new
CorrZ
that is different fromCorrY
in that it usesAlignment2024
, but as far as I know, that should be the only difference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CorrZ
, as implemented, removes theOSectorAlign
chain option that implements a TPC distortion correction I implemented. I cannot remember a presentation justifying specifically the removal of this distortion correction, but I welcome being pointed to such.