Remove the St_geant_Maker dependencies in the event generator to starsim bridge #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it require any further testing? |
It shouldn't. The refactoring was straightforward (just lifting the calls to add particles out of St_geant_Maker and into the bridge.) Test with single particles showed that hits were being registered in detectors. So this should be good to go. |
plexoos
approved these changes
Nov 2, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
…sim bridge (star-bnl#616) Use direct calls into the starsim / GEANT3 libraries to push particles onto the G3 stack, eliminating the dependence on St_geant_Maker and the version of GEANT3 required by starsim. This will allow the event generator framework to function with either our legacy starsim / St_geant_Maker framework, or the new VMC / StGeant4Maker framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use direct calls into the starsim / GEANT3 libraries to push particles onto the G3 stack, eliminating the dependence on St_geant_Maker and the version of GEANT3 required by starsim. This will allow the event generator framework to function
with either our legacy starsim / St_geant_Maker framework, or the new VMC / StGeant4Maker framework.