Upgrade to spoon2.0.0-snapshot, android3.0.0 and gradle 4.1

[dweebo]

To fix issues discussed in #155 and to prepare for android build tools 3.0.0.

[ligi]

Great initiative - but I have the same problem travis has - as the PR uses a SnapShot of spoon but does not add the SnapShot maven repo. This should help:

--- a/build.gradle
+++ b/build.gradle
@@ -33,6 +33,7 @@ repositories {
   mavenLocal()
   google()
   jcenter()
+  maven { url 'https://oss.sonatype.org/content/repositories/snapshots' } 
 }
 

[dweebo]

Oh nice thanks! I couldn't figure out where spoon kept snapshots. I'll update in a bit

[dweebo]

3.0.0 is officially out now too so will upgrade to that and test as soon as i can

[ligi]

one question (blocks me from using 3.0.0 for now) don't you experience: https://issuetracker.google.com/issues/68275433

[dweebo]

@ligi haven't seen that error

[autonomousapps]

Hi! Just wondering when this might get merged and published? I also tried to find a snapshot build, but it doesn't seem to be available. https://oss.sonatype.org/content/repositories/snapshots/com/stanfy/spoon/spoon-gradle-plugin/

[ligi]

@dweebo thanks for the info and good for you ;-)
@autonomousapps you can get a snapshot via jitpack

[autonomousapps]

@ligi can you show me the code for that? Gradle still can't find it. I have:

buildscript {
    repositories {
        jcenter()
        maven { url 'https://maven.fabric.io/public' }
        maven { url 'https://plugins.gradle.org/m2/' }
        maven { url 'https://maven.google.com' }
        maven { url 'https://jitpack.io' }
    }
    dependencies {
        // elided
        classpath 'com.stanfy.spoon:spoon-gradle-plugin:2.0.0-SNAPSHOT'
    }
}

[ligi]

classpath 'com.github.dweebo:spoon-gradle-plugin:5c318830a43c01dc098b745278168e12fb55dedc' should do the trick

[autonomousapps]

Thank you, that worked (almost), but now it's complaining it can't find com.squareup.spoon:spoon-runner:2.0.0-SNAPSHOT, which it says is required by com.github.dweebo:spoon-gradle-plugin:5c318830a43c01dc098b745278168e12fb55dedc

[ligi]

you need to add
maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
to the repositories for your app

[autonomousapps]

Yes, sorry! I removed that after you said to use jitpack. All is well now with that re-added to repos block. For anyone else that sees this, here is a complete working example:

buildscript {
    repositories {
        maven { url 'https://jitpack.io' }
        maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
    }
    dependencies {
        classpath 'com.github.dweebo:spoon-gradle-plugin:5c318830a43c01dc098b745278168e12fb55dedc'
    }
}

[jaredsburrows]

@autonomousapps @ligi When can we get a new release. The last release on this plugin was over a year ago :(

[ligi]

@jaredsburrows I cannot tell you as I am not the maintainer ..-)

[jaredsburrows]

@ligi Alright.

@autonomousapps Combining it all together:

buildscript {
    repositories {
        maven { url "https://jitpack.io" }
        maven { url "https://oss.sonatype.org/content/repositories/snapshots" }
    }

    dependencies {
        classpath "com.squareup.spoon:spoon-runner:2.0.0-SNAPSHOT"
        classpath "com.github.dweebo:spoon-gradle-plugin:5c318830a43c01dc098b745278168e12fb55dedc"
    }
}

Both tasks show up again:

spoon - Runs all the instrumentation test variations on all the connected devices
spoonDebugAndroidTest - Runs instrumentation tests on all the connected devices for 'debugAndroidTest' variation and generates a report with screenshots

[autonomousapps]

Cool. I didn't have to add an explicit dependency on the spoon-runner, since the spoon-gradle-plugin pulled that in automatically. 🤷‍♂️

[jaredsburrows]

@autonomousapps did the output change of the artifacts?

[autonomousapps]

@jaredsburrows Good question. I'm currently wrestling with Jenkins to get it to build my project with all the updates. The last build didn't have usual Spoon report, so it's possible the artifact location has changed.

[ligi]

square/spoon@53a63fe was just merged - @jaredsburrows can you ping when a version of your plugin contains this?

[jaredsburrows]

@ligi Support added here in 1.1.11-SNAPSHOT.

[jaredsburrows]

@dweebo @ligi @autonomousapps Are you all seeing this? square/spoon#498

No xml junit reports are being generated.

[jaredsburrows]

@ligi Can you verify that "single instrumentation" is working for you?

Also, @dweebo @autonomousapps are you all seeing what I am seeing?

[ligi]

@jaredsburrows sorry - did not yet find time to try - also a bit reluctant using such snapshot versions as I want my builds to be reproducible as possible - as far as I see this way the plugin could change from build to build - which means the build could pass one time and fail another time.
But might try to use it via jitpack with a referenced commit-hash soon - should also work. PS does your plugin support the spoon flag --fail-if-no-device-connected ?

[jaredsburrows]

@ligi I need to publish a new release but the SNAPSHOT is stable and does support fail-if-no-device-connected. I also have updated it to support "single instrumentation". Regardless of snapshot or not, you still have to use the SPOON 2.0.0 SNAPSHOT for this plugin to work.

[ligi]

Ah right - dam - do you have any idea when spoon 2.0.0 will be released?

[jaredsburrows]

@ligi No :(

[hram]

Hi all
Can you check SNAPSHOT how it works if specify package for running tests only from this package?
In my project when I set instrumentation arguments like this

instrumentationArgs = ["package=my.app.package.name"]

I haw exception in logcat

E/AndroidJUnitRunner: Fatal exception when running tests
java.lang.IllegalArgumentException: Ambiguous arguments: cannot provide both test package and test class(es) to run
at android.support.test.internal.runner.TestRequestBuilder.validate(TestRequestBuilder.java:828)
at android.support.test.internal.runner.TestRequestBuilder.build(TestRequestBuilder.java:789)
at android.support.test.runner.AndroidJUnitRunner.buildRequest(AndroidJUnitRunner.java:487)
at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:373)
at my.package.app.runner.UnlockDeviceAndroidJUnitRunner.onStart(UnlockDeviceAndroidJUnitRunner.java:44)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2075)

[jaredsburrows]

@hram Yes. This is because by default Spoon 2 runs in separate instrumentation. So you need to use the singleInstrumentationCall = true from https://github.com/jaredsburrows/gradle-spoon-plugin to make it work. Or you can use annotations such as @SmallTest.

[hram]

@jaredsburrows thank you very much!
I will try
As workaround I configure Suite with all testes what I needed
And configure spoon with parameter 'className' to run this Suite

[jaredsburrows]

@hram Great! It really should be reported to spoon. As it is a limitation to adb shell am instrumentation.

[jimxj]

Could you update it to 3.0.1 ?

[jaredsburrows]

Try using https://github.com/jaredsburrows/gradle-spoon-plugin.

[jimxj]

Actually I am trying :)

[dweebo]

@jimxj I upgraded to 3.0.1 and fixed an issue with a recent change to spoon snapshot 2.0.0

[jaredsburrows]

@dweebo I love the map.

[hram]

@jaredsburrows can you help me?
I was trying to set package name as

instrumentationArgs = ["package my.app.testspoon"]

and set parameter as you sad

singleInstrumentationCall = true

but spoon task execuded fith error

java.lang.NoSuchMethodError: com.squareup.spoon.SpoonRunner$Builder.setInstrumentationArgs(Ljava/util/List;)Lcom/squareup/spoon/SpoonRunner$Builder;
at com.jaredsburrows.spoon.SpoonTask.spoonTask(SpoonTask.kt:73)

I changed params as

instrumentationArgs = ["package=my.app.testspoon"]

and no luck (

[jaredsburrows]

@hram Sorry. I need to update the documentation. Your instrumentationArgs = ["package my.app.testspoon"] should be instrumentationArgs = ["package=my.app.testspoon"].

I need to support both List and Map.

[hram]

@jaredsburrows but as I sad

I changed params as
instrumentationArgs = ["package=my.app.testspoon"]
and no luck (

[jaredsburrows]

@hram Maybe it is a bug. Can you post an issue in that projects issues?

[hram]

@jaredsburrows yes I can )
jaredsburrows/gradle-spoon-plugin#8

[Igorshp]

Is anythig blocking this from being merged?