Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load_boston in README.md #340

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Update load_boston in README.md #340

merged 9 commits into from
Nov 20, 2023

Conversation

jyx-su
Copy link
Contributor

@jyx-su jyx-su commented Nov 6, 2023

Fixed #339

@jyx-su jyx-su requested a review from ryan-wolbeck November 6, 2023 02:36
Copy link
Collaborator

@ryan-wolbeck ryan-wolbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add these same updates to examples/regression.py and examples/survival.py?

https://github.com/stanfordmlgroup/ngboost/blob/master/examples/regression.py

@jyx-su
Copy link
Contributor Author

jyx-su commented Nov 6, 2023

Done @ryan-wolbeck

Copy link
Collaborator

@ryan-wolbeck ryan-wolbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove pandas from the pyproject.toml we have chosen to remove this as a dependency in a previous PR here #318

In order to get the tests to pass, run black on all the files changed here.

@jyx-su
Copy link
Contributor Author

jyx-su commented Nov 8, 2023

Removed the pandas dependency and ran "black ."
Can you advise on why the tests still failed?

@ryan-wolbeck
Copy link
Collaborator

ryan-wolbeck commented Nov 8, 2023

the order of your imports is in the incorrect style

isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /home/runner/work/ngboost/ngboost/examples/regression.py
Fixing /home/runner/work/ngboost/ngboost/examples/survival.py

If you have make and poetry installed in your environment you can just run
make lint and it will run black and fix the import issues then you can make another commit

make lint run's the following
poetry run pre-commit run --hook-stage manual --all-files

@ryan-wolbeck ryan-wolbeck merged commit f8dce61 into master Nov 20, 2023
8 checks passed
@jyx-su jyx-su deleted the load_boston_removed branch November 20, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_boston removed from sklearn
2 participants