Adjust API error UI on AskNoora #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tommybru is attempting to deploy a commit to the stanford-oval Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Edits the UI when AskNoora API call fails. The new version better communicate to the user that they have to try again later and that the default reply is not a real response.
Old
New
How:
Adds a
successparameter on the API result call and use it to conditionally render a successful reply or one asking users to try againEdits the default reply to be "Noora couldn't think of a reply. Please try again later."
Testing
I do not yet have access to the Azure API, if it could be tested that where I have placed the
success = Trueactually works with our API call.