Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurry right click menus #2882

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

DarkArc
Copy link
Contributor

@DarkArc DarkArc commented Aug 30, 2024

This is an untested a change to resolve a problem I noticed in the desktop app and then corrected by adjusting the CSS in the inspector.

The font blurriness seems to only occur when the pixels are odd numbers, thus by using even numbers we can avoid the blurry right click menu that sometimes appears.

@DarkArc
Copy link
Contributor Author

DarkArc commented Aug 30, 2024

Before After
image image

After doing some reading, the original call is likely better for rendering performance and that's why it was used.
@DarkArc
Copy link
Contributor Author

DarkArc commented Aug 31, 2024

This is now tested.

@moughxyz
Copy link
Member

moughxyz commented Sep 9, 2024

How can we replicate this? Changing the translate-x/y value in inspector to an odd number doesn't yield a blurry menu.

@DarkArc
Copy link
Contributor Author

DarkArc commented Sep 9, 2024

That's interesting; I see this on two devices when using the desktop app. Both devices are running Linux and using the standard notes desktop app flatpak.

The device with the 4k monitor the effect is more subtle. The other device is a framework laptop.

One thought is it might have something to do with display scaling factors in chromium under Linux.

@moughxyz
Copy link
Member

moughxyz commented Sep 9, 2024

Can you share a screen recording?

@DarkArc
Copy link
Contributor Author

DarkArc commented Sep 9, 2024

I'm not really sure what that would do... It's exactly as I described and the screenshots show above.

@DarkArc
Copy link
Contributor Author

DarkArc commented Sep 10, 2024

I really think this was a waste of (my) time but here's the requested video.
https://github.com/user-attachments/assets/6d5b8bc0-08b0-4053-b3c8-88db279415b7

@DarkArc
Copy link
Contributor Author

DarkArc commented Sep 10, 2024

Here's a better one (higher resolution)
https://github.com/user-attachments/assets/55272db0-0c4f-4101-b61b-9043abaf0192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants