-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blurry right click menus #2882
base: main
Are you sure you want to change the base?
Conversation
packages/web/src/javascripts/Components/Popover/GetPositionedPopoverStyles.ts
Outdated
Show resolved
Hide resolved
After doing some reading, the original call is likely better for rendering performance and that's why it was used.
This is now tested. |
How can we replicate this? Changing the translate-x/y value in inspector to an odd number doesn't yield a blurry menu. |
That's interesting; I see this on two devices when using the desktop app. Both devices are running Linux and using the standard notes desktop app flatpak. The device with the 4k monitor the effect is more subtle. The other device is a framework laptop. One thought is it might have something to do with display scaling factors in chromium under Linux. |
Can you share a screen recording? |
I'm not really sure what that would do... It's exactly as I described and the screenshots show above. |
I really think this was a waste of (my) time but here's the requested video. |
Here's a better one (higher resolution) |
This is
an untesteda change to resolve a problem I noticed in the desktop app and then corrected by adjusting the CSS in the inspector.The font blurriness seems to only occur when the pixels are odd numbers, thus by using even numbers we can avoid the blurry right click menu that sometimes appears.