chore(ci): correct keypair alias [skip e2e]

standardnotes · Oct 11, 2024 · d178213 · d178213
1 parent bb0d2d2
commit d178213
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/desktop.release.reuse.yml b/.github/workflows/desktop.release.reuse.yml
@@ -248,6 +248,8 @@ jobs:
 
   Windows:
     runs-on: windows-latest
+    env:
+      SM_KEYPAIR_ALIAS: ${{ secrets.SM_KEYPAIR_ALIAS }}
 
     defaults:
       run:
@@ -294,14 +296,6 @@ jobs:
         run: |
           export DEBUG='electron-builder'
 
-          echo "version=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
-          echo "KEYPAIR_NAME=snkeypair" >> $GITHUB_OUTPUT
-          echo "CERTIFICATE_NAME=sncertificate" >> $GITHUB_OUTPUT
-
-          echo "::set-output name=version::${GITHUB_REF#refs/tags/v}"
-          echo "::set-output name=KEYPAIR_NAME::snkeypair"
-          echo "::set-output name=CERTIFICATE_NAME::sncertificate"
-
           echo "SM_HOST=${{ secrets.SM_HOST }}" >> "$GITHUB_ENV"
           echo "SM_API_KEY=${{ secrets.SM_API_KEY }}" >> "$GITHUB_ENV"
           echo "SM_CLIENT_CERT_FILE=D:\\Certificate_pkcs12.p12" >> "$GITHUB_ENV"

diff --git a/packages/desktop/scripts/windowsSign.js b/packages/desktop/scripts/windowsSign.js
@@ -1,7 +1,9 @@
 exports.default = async function (configuration) {
   if (configuration.path) {
+    const keypairAlias = process.env.SM_KEYPAIR_ALIAS
+
     require('child_process').execSync(
-      `smctl sign --keypair-alias=snkeypair --input "${String(configuration.path)}" --verbose`,
+      `smctl sign --keypair-alias="${keypairAlias}" --input "${String(configuration.path)}" --verbose`,
       {
         stdio: 'inherit',
       },