lint: Test and improve PNG transparency check (f-019) #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
se lint
doesn't recognize some types of PNG transparency. This adds small test images with different types of transparency/non-transparency, and some additional code to cover:image.mode == "LA"
: grayscale with an alpha channel. Similar to the RGBA that was already supported.image.mode == "P"
: a palette-based images, but with multiple transparency levels. This means thatimage.info["transparency"]
is a bytes string with an 0-255 alpha level for every indexed color. The current version ofhas_transparency
only expected one single transparent index.The test includes some transparent and some non-transparent images, where some of the non-transparent images have an unused alpha channel.
PIL.Image
details per image: