Simplify inner_text implementation using lxml's text method #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using regex to remove tags and attributes after the fact. https://lxml.de/api/lxml.etree-module.html#tostring This also eliminates the need to perform HTML unescaping. On my local machine, this reduces the time spent in the inner_text method on Don Quixote from 1.5 seconds to 0.04 seconds.
acabal
reviewed
Jun 22, 2024
| @@ -34,3 +34,14 @@ def test_add_landmark_with_title(): | |||
| add_landmark(dom, "file", landmarks) | |||
|
|
|||
| assert landmarks[0].title == "Bar" | |||
|
|
|||
| def test_inner_text(): | |||
There was a problem hiding this comment.
Great, glad to see we're getting some tests in here. Do you have to also rebuild the test golden files when adding a test?
There was a problem hiding this comment.
Not sure: I added this test and re-ran pytest and everything worked fine.
That doesn't seem to apply to |
|
OK then, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using regex to remove tags and attributes after the fact.
https://lxml.de/api/lxml.etree-module.html#tostring
This also eliminates the need to perform HTML unescaping.
On my local machine, this reduces the time spent in the inner_text method on Don Quixote from 1.5 seconds to 0.04 seconds.
We add a basic test for the inner_text method in a preliminary commit to demonstrate that the behavior of the new implementation is equivalent.