-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop support for Node.js v10 #252
Conversation
We may want to require one of the later Node 12 releases, to be able to use all the newest features in it, just like we did with Node 10 |
Yes, do you have a specific Node.js v12 version in particular we could require ? |
I tried finding a good comparison, but eg https://node.green/ has no easy way to just compare two versions, so right now I don't know if there's any substantial new addition language wise. And haven't checked the Node.js API additions at all. |
Right, I think it is not necessary to require a newer Node.js v12 version if we don't need it. EDIT: To ease the migration from CommonJS to ESM, I suggest to support these Node.js versions: |
629c023
to
38806db
Compare
38806db
to
b23c84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 👍
Since this is a breaking change I think that we should also convert to ESM before cutting the next release. I can submit a PR unless someone else is working on it
Co-authored-by: Linus Unnebäck <[email protected]>
@LinusU We had planned doing that for |
Focusing on this for |
Yes, you can open a PR. 😄 |
What changes did you make? (Give an overview)
node-version
matrix in CI with GitHub ActionsIs there anything you'd like reviewers to focus on?
BREAKING CHANGE: Minimum supported Node.js version >= 12.0.0