Refactor / p5xr consolidation / Fix AR mode #215
Conversation
Removed button argument because it was always created and overloaded afer construction
Removed p5.instance._decrementPreload as it was launching p5 in 2D mode for some reason
|
This looks exciting! I just read through the code and everything makes sense. Later this month I can get my hands on a headset for testing but let me know if you would prefer a more expedited timeline. I would also be open to the idea of promoting your permissions and allowing you to merge sooner and I can follow up with bug reports if something is amiss once I am able to actually test. |
|
Thanks! There is this Immersive Web Emulator which is nice for testing. I think I prefer to merge once you could check things. I setup npm publishing from my fork as well, I think it's useful for testing out features where it's unclear what the p5 like api should be, like in #216 Since there don't seem to be any other active contributors at the moment I think the risk of conflicts is pretty minimal. So better keep it as is for now IMO. |
| this.xrSession = null; | ||
| this.xrRefSpace = null; | ||
| this.xrViewerSpace = null; | ||
| this.xrHitTestSource = null; | ||
| this.frame = null; | ||
| this.gl = null; | ||
| this.curClearColor = color(255, 255, 255); |
There was a problem hiding this comment.
Oops, silly mistake
| this.viewer = new p5xrViewer(); | ||
|
|
||
| this.requiredFeatures = requiredFeatures; | ||
| this.optionalFeatures = optionalFeatures; |
There was a problem hiding this comment.
This interface might be interesting to offer flexibility from the user's perspective in the future.
src/p5xr/core/p5xr.js
Outdated
| // }); | ||
| // this.addInlineViewListeners(this.canvas); | ||
| // } | ||
| // }); |
There was a problem hiding this comment.
I am a fan of either commenting to explain a commented out chunk or just deleting the deprecated code
There was a problem hiding this comment.
I'm putting this back, this is necessary for inline mode to work
As discussed in #207, this PR consolidates common code between
p5xrandp5arintop5xrin preparation for a more feature based approach. Initially I was looking to fix AR mode for the use with my Quest 3, but doing the refactor at the same time made the most sense.Let me know if you would like me to squash the commits into a single one, or if you prefer "atomic commits".
Here are the changes in reverse chronological order:
Removed p5.instance._decrementPreload as it was launching p5 in 2D mode for
some reason
Removed button argument because it was always created and overloaded afer
construction
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia