Readme p5.xr min version update #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebGL2 support and p5.instance.webglVersion check was introduced in version 1.7.0 https://github.com/processing/p5.js/releases/tag/v1.7.0. Getting webgl context will fail if in older versions. Example mentioned in stalgiag#203 currently fails because of this
|
I don't think there is a good way to update p5 web editor examples, should I just update the links with working examples on my p5 web editor account when I fix something? https://editor.p5js.org/TiborUdvari/sketches/fgA0L9jQ6 |
|
Thanks for this! Yeah I think it makes sense to update the editor sketch links to whoever is hosting the most recent example. The web editor offers a lot of advantages for first time users (immediately duplicate example, try in browser without running local server) but it does make editing hard. Another option is that we could make a p5.xr user and have a secret stored in the repo that has the login info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGL2 support and p5.instance.webglVersion check was introduced in version 1.7.0 https://github.com/processing/p5.js/releases/tag/v1.7.0. Getting webgl context will fail if in older versions. Example mentioned in #203 currently fails because of this.
p5 editor examples should be updated if possible.