Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Conversation

Sanaullahbugti
Copy link

home page translation

@netlify
Copy link

netlify bot commented Jul 12, 2019

Deploy preview for ur-reactjs ready!

Built with commit ae25c9f

https://deploy-preview-7--ur-reactjs.netlify.com

@jabranr jabranr self-assigned this Jul 12, 2019
@jabranr jabranr self-requested a review July 12, 2019 16:38
@@ -50,7 +50,7 @@ class Home extends Component {
return (
<Layout location={location}>
<TitleAndMetaTags
title="React &ndash; A JavaScript library for building user interfaces"
title="ری ایکٹ &ndash; یے جاوا اسکرپٹ کی لا ئبریری ھے جو یوزر انٹرفیسس بنانے میں کا م آ تی ھے"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not translate the words that represent products i.e. React, JavaScript etc. Read the universal style guide and see examples from other translation projects such as React docs in Arabic.

@@ -111,7 +111,7 @@ class Home extends Component {
fontSize: 60,
},
}}>
React
ری ایکٹ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not translate the words that represent products i.e. React, JavaScript etc. Read the universal style guide and see examples from other translation projects such as React docs in Arabic.

@@ -133,7 +133,7 @@ class Home extends Component {
fontSize: 30,
},
}}>
A JavaScript library for building user interfaces
یے جا و ا اسکرپٹ کی لا ئبریری ھے جو یوزر انٹرفیسس بنانے میں کا م آ تی ھے
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

</ButtonLink>
</CtaItem>
<CtaItem>
<ButtonLink to="/tutorial/tutorial.html" type="secondary">
Take the Tutorial
سبق لے لو
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better as

سبق حاصل کریں

</ButtonLink>
</CtaItem>
<CtaItem>
<ButtonLink to="/tutorial/tutorial.html" type="secondary">
Take the Tutorial
سبق لے لو
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better as

سبق حاصل کریں

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I will make changes and will create a new issue

@jabranr
Copy link
Contributor

jabranr commented Jul 12, 2019

@Sanaullahbugti Thank you for participating in this translation project.

If you have not already gone through Urdu Translation Progress page then I highly recommend to do so. You also need to create a new issue and let us know about the page you wish to translate so we can assign it to you in there. This helps everyone be informed about the progress. Any questions, feel free to ask.

@jabranr jabranr assigned Sanaullahbugti and unassigned jabranr Jul 12, 2019
@jabranr
Copy link
Contributor

jabranr commented Jul 18, 2019

Reference #9

@jabranr
Copy link
Contributor

jabranr commented Jun 10, 2020

It has been inactive for a long time now. I am going to close this. Please open a new pull request if needed by following the feedback given in this review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants