Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

translates: /docs/hooks-intro.md #44

Merged
merged 13 commits into from
May 23, 2020
Merged

translates: /docs/hooks-intro.md #44

merged 13 commits into from
May 23, 2020

Conversation

Jacco
Copy link
Contributor

@Jacco Jacco commented Nov 30, 2019

New PR to support suggestions

@Jacco Jacco changed the title translate: Hooks inro translate: Hooks intro Nov 30, 2019
@netlify
Copy link

netlify bot commented Nov 30, 2019 •
edited
Loading

Deploy preview for nl-reactjs ready!

Built with commit a507c32

https://deploy-preview-44--nl-reactjs.netlify.com

@degeens degeens self-requested a review November 30, 2019 10:11
@degeens degeens mentioned this pull request Nov 30, 2019
Closed
@tesseralis tesseralis mentioned this pull request Nov 30, 2019
Closed
93 tasks
degeens
degeens suggested changes Dec 1, 2019
View reviewed changes
Copy link
Contributor

@degeens degeens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go... Let me know if you disagree with something. 😉

In addition to my suggestions, you should indicate that a linked article is English by using (Engels). Feel free to check the glossary & style guidelines for more info.

Thank you for your work so far! 💪

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@degeens degeens added the ⏳ Waiting for Author Waiting for the author to address the feedback/questions/suggestions. label Dec 1, 2019
Jacco Kulman and others added 4 commits December 1, 2019 16:36
@degeens
Apply suggestions from code review
4ce8240 
Thanks for reading through @degeens :-)

I have accepted most. Only few need more discussion :-)

Co-Authored-By: Stijn Geens <[email protected]>
@degeens
Apply suggestions from code review
9c8125e 
Zag eerst de wijziging niet. "hechten" vindt ik ook niet heel mooi :S

Co-Authored-By: Stijn Geens <[email protected]>
Undo menu translations
6bd5ae2
Merge branch 'hook-intro-menu' of https://github.com/Jacco/nl.reactjs…
07bf403 
….org into hook-intro-menu
@Jacco Jacco changed the title translate: Hooks intro translates: /docs/hooks-intro.md Dec 1, 2019
degeens
degeens reviewed Dec 3, 2019
View reviewed changes
content/docs/nav.yml Outdated Show resolved Hide resolved
degeens
degeens reviewed Dec 4, 2019
View reviewed changes
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
degeens
degeens reviewed Dec 4, 2019
View reviewed changes
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@Jacco
Copy link
Contributor Author

Jacco commented Dec 4, 2019

@Keraito can you also review?

@degeens degeens requested a review from Keraito December 6, 2019 16:35
@degeens degeens added 🔍 Looking for Reviews Translation is done and ready/looking for review. and removed ⏳ Waiting for Author Waiting for the author to address the feedback/questions/suggestions. labels Dec 8, 2019
Keraito
Keraito approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@Keraito Keraito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, awesome work! I've got a few comments and also suggestions, so please look into those!

content/docs/hooks-intro.md Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@degeens degeens added ⏳ Waiting for Author Waiting for the author to address the feedback/questions/suggestions. and removed 🔍 Looking for Reviews Translation is done and ready/looking for review. labels Dec 10, 2019
@Jacco
Copy link
Contributor Author

Jacco commented Dec 10, 2019

@Keraito thx for the review

Changed a few of the suggestions slightly.

Only three thing left to discuss:
https://github.com/reactjs/nl.reactjs.org/pull/44/files

@Keraito Keraito removed the ⏳ Waiting for Author Waiting for the author to address the feedback/questions/suggestions. label Dec 30, 2019
@Keraito
Copy link
Contributor

Keraito commented Dec 30, 2019

Looks good, need to trigger a rebuild of some kind and then merge

@Jacco
Copy link
Contributor Author

Jacco commented Jan 6, 2020

Looks good, need to trigger a rebuild of some kind and then merge

You mean the ci/circle build?

@Keraito
Copy link
Contributor

Keraito commented Jan 6, 2020

Yes

@Jacco
Copy link
Contributor Author

Jacco commented Jan 6, 2020

For the sync PRs it runs automayically...

@Jacco Jacco merged commit 1c5d1b9 into stale-reactjs-org-translations:master May 23, 2020
@Jacco Jacco added this to the Next Steps milestone Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@degeens degeens degeens approved these changes

@Keraito Keraito Keraito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Steps
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacco @Keraito @degeens