Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

translates: lists-and-keys #26

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

translates: lists-and-keys #26

wants to merge 11 commits into from

Conversation

ronderksen
Copy link

@ronderksen ronderksen commented Feb 27, 2019 •
edited by Jacco
Loading

  • line number fixes
  • comments + display text in code
  • compare to english
  • common terms
  • hyphens
  • `` codify english
  • links checken

@ronderksen ronderksen added the 🚧 Translation In Progress Still working on it! label Feb 27, 2019
@tesseralis tesseralis mentioned this pull request Feb 27, 2019
Closed
93 tasks
@netlify
Copy link

netlify bot commented Feb 27, 2019 •
edited
Loading

Deploy preview for nl-reactjs ready!

Built with commit dd0d46d

https://deploy-preview-26--nl-reactjs.netlify.app

@tesseralis
Copy link
Contributor

@ronderksen how is it going with this translation? Is it ready for review? Since it's been a while, please let the maintainers know if you are unable to finish it and would like some help!

@ronderksen ronderksen marked this pull request as ready for review April 30, 2019 21:42
@ronderksen ronderksen added 🔍 Looking for Reviews Translation is done and ready/looking for review. and removed 🚧 Translation In Progress Still working on it! labels Apr 30, 2019
SleeplessByte
SleeplessByte reviewed May 28, 2019
View reviewed changes
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
@Jacco Jacco changed the title translating lists-and-keys.md translates: lists-and-keys May 24, 2020
@Jacco
Copy link
Contributor

Jacco commented May 25, 2020

@ronderksen @SleeplessByte are you OK with me cherry picking some of the suggestions and try to move forward with the project? It has been a year since the suggestions were made.

@degeens what do you think?

Jacco and others added 2 commits May 28, 2020 14:05
@Jacco @SleeplessByte
Apply suggestions 21 suggestions from SleeplessByte
cb27a64 
Note to self: i do not like 'extraheren'
Text needs another look

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
@Jacco
Regels weer terug op oorspronkelijke
c71d312
Jacco
Jacco approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@Jacco Jacco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 comment from myself

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
@Jacco @SleeplessByte
Eight changes
5473b41 
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
@degeens degeens self-requested a review May 28, 2020 13:27
@Jacco Jacco added this to the "Official" Translation milestone Jun 7, 2020
@Jacco Jacco added ✅ PR synced This PR is synced with latest master 👍 Need +1 Already approved by 1 reviewer, looking for another. and removed 🔍 Looking for Reviews Translation is done and ready/looking for review. labels Jun 10, 2020
Jacco added 2 commits June 10, 2020 21:21
@Jacco Jacco added the 🏁 Ready to Merge This PR is approved and ready to be merged with the master branch label Jun 10, 2020
@Jacco
Copy link
Contributor

Jacco commented Jun 10, 2020

@rickbeerendonk heb jij tijd om deze goed te keuren? Ik denk dat ie nu goed is.

Enige twijfel heb ik nog over of we "Key" en "Keys" willen gebruiken of overal "Sleutel" en "Sleutels" en alleen als er naar code wordt verwezen key.

Maar dat kan ook later nog een keer.

StijnLoose
StijnLoose reviewed Nov 7, 2020
View reviewed changes
content/docs/lists-and-keys.md

A good rule of thumb is that elements inside the `map()` call need keys.
Een goede vuistregel is dat de elementen binnen een `map()` aanroep keys nodig hebben.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Als ik een suggestie mag doen:
Een vuistregel is dat de elementen binnen de map() functie keys vereisen.
functie is nog niet helemaal goed vind ik zelf, maar operator is dan weer Engels.

@degeens degeens removed their request for review January 13, 2021 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StijnLoose StijnLoose StijnLoose left review comments

@jochenboesmans jochenboesmans jochenboesmans left review comments

@SleeplessByte SleeplessByte SleeplessByte left review comments

@Jacco Jacco Jacco approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
✅ PR synced This PR is synced with latest master 🏁 Ready to Merge This PR is approved and ready to be merged with the master branch 👍 Need +1 Already approved by 1 reviewer, looking for another.
Projects
None yet
Milestone
"Official" Translation
Development

Successfully merging this pull request may close these issues.
6 participants
@ronderksen @tesseralis @Jacco @SleeplessByte @jochenboesmans @StijnLoose