This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Sync with reactjs.org @ 543c7a0d #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [beta] Fix Chai recipe in docs * Cut down recipe to 3 points * Adjust explanation Co-authored-by: Dan Abramov <[email protected]>
In the paragraph: ``` You can wrap an update into a transition only if you have access to the set function of that state. If you want to start a transition in response to some prop or a custom Hook return value, try useDeferredValue instead. ``` The "useDeferredValue" link pointed to "usedeferredvalue" which is an invalid URL, this commit fixes that.
* [beta] Add StrictMode docs * More usages * Remove WIP * Add legacy string refs * Add legacy context * stuff Co-authored-by: Dan Abramov <[email protected]>
* [beta] Add findDOMNode * info Co-authored-by: Dan Abramov <[email protected]>
* [Beta] Fixed Semicolon missing in a code snippet. #5337 * [Beta] Fixed Semicolon missing in a code snippet. reactjs#5337
* [wip] createPortal * createPortal API * edits * more Co-authored-by: Dave McCabe <[email protected]>
* [Beta] useLayoutEffect API * more * tweak * bla
* [Beta] useEvent -> useEffectEvent * tweak
Proposing a minor grammatical correction on the useEffect API documentation page for triggering an animation example section.
The section under consideration 'Removing unnecessary function dependencies' should use the text 'createOptions function' instead of 'options object' to match the given example correctly. The 'options object' text is being used correctly for the previous section which talks about 'Removing unnecessary object dependencies' however, it must be updated for this section.
Thanks to Alex H for reporting.
There's 5 instances in this document in which the casing of a file name begins with lower case, which makes it inconsisnent both with the page and the entire tutorial.
* matched the curly braces #issues5887 Added matched the curly braces on the official website tutorial. #issues5887 * Update index.md --------- Co-authored-by: dan <[email protected]>
… naming convention (#5886)
* Fix casing for consistency There's 5 instances in this document in which the casing of a file name begins with lower case, which makes it inconsisnent both with the page and the entire tutorial. * Fix improper idiom usage The phrase "most of the times" is incorrect and would only make sense in the context of a larger sentence. The phrase is actually "most of the time" and is used in place of "usually".
Update referencing-values-with-refs.md
Fix: typo in "Animation Event Handler function" example
* Legacy API, Component: fix href for getDerivedStateFromProps * Legacy API, Component: fix href for getDerivedStateFromProps
* fix: url * fix: check if it works * fix * fix * use legacy link * chore: add to vercel.json
* Fix minor grammar mistakes * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 543c7a0
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.