Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assign to self button #921

Closed

Conversation

Marvel-Ib
Copy link
Contributor

Describe your changes

remove assigning to self functionality

Screen.Recording.2023-11-10.at.05.01.20.mov

Issue ticket number and link

#918

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

Okay I see you removed the button. Let me talk with the team about whether we need to remove or comment out the code too.

@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Nov 10, 2023

Hey @Marvel-Ib. We also would like to comment out the api call in the backend as well so that the api won't get exploited.

In other words we want the code to still be there but not active.

Are you familiar with go? If so, can you add that to this PR?

@ecurrencyhodler
Copy link
Contributor

I also assigned this 100k sat bounty to you: https://community.sphinx.chat/bounty/685

@Marvel-Ib
Copy link
Contributor Author

@elraphty Hi, please can you help review this and point out if there is anywhere else in the go code I need to remove

@Marvel-Ib
Copy link
Contributor Author

@elraphty still waiting for a review

@elraphty
Copy link
Contributor

@Marvel-Ib in tribes.go GenerateInvoice function Tribes.go remove these

   AssignedHours:  assigedHours,
   CommitmentFee:  commitmentFee,
   BountyExpires:  bountyExpires,

and also remove the ASSIGN conditional statement from bounty.go

    else if invoice.Type == "ASSIGN" {
	bounty, err := db.DB.GetBountyByCreated(uint(invData.Created))

	if err == nil {
	    bounty.Assignee = invData.UserPubkey
	    bounty.CommitmentFee = uint64(invData.CommitmentFee)
	    bounty.AssignedHours = uint8(invData.AssignedHours)
	    bounty.BountyExpires = invData.BountyExpires
	} else {
	   fmt.Println("Fetch Assign bounty error ===", err)
	}

	db.DB.UpdateBounty(bounty)
    }

@elraphty elraphty closed this Dec 1, 2023
@ecurrencyhodler
Copy link
Contributor

@Marvel-Ib we are going to give you partial payout of the bounty for this. We need to get this addressed so Raph will be taking it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants