Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag Endpoint management #2317

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ekep-Obasi
Copy link
Contributor

@Ekep-Obasi Ekep-Obasi commented Jan 2, 2025

Describe your changes

Issue ticket number and link

Middleware: https://community.sphinx.chat/bounty/3120
Feature Flag Endpoints: https://community.sphinx.chat/bounty/3121
Management endpoints: https://community.sphinx.chat/bounty/3124

https://www.loom.com/share/06d3cd036e01418fb083bac2bb4263ee?sid=06cd25f9-6961-4339-acb5-3ec1067aa00a

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@Ekep-Obasi
Copy link
Contributor Author

@humansinstitute @tobi-bams Please review this PR

@humansinstitute
Copy link
Contributor

@tobi-bams can you review this one when you come online.

db/feature_flags.go Outdated Show resolved Hide resolved
db/feature_flags.go Outdated Show resolved Hide resolved
handlers/feature_flags.go Outdated Show resolved Hide resolved
@Ekep-Obasi Ekep-Obasi force-pushed the feat/feature-flag-module branch 2 times, most recently from e4a2dc2 to 3bc6163 Compare January 2, 2025 15:53
@humansinstitute
Copy link
Contributor

@Ekep-Obasi can you review the conflicts so we can look at merging this and getting the front end in?

@Ekep-Obasi Ekep-Obasi force-pushed the feat/feature-flag-module branch from 3bc6163 to 297884e Compare January 3, 2025 10:14
@Ekep-Obasi
Copy link
Contributor Author

@Ekep-Obasi can you review the conflicts so we can look at merging this and getting the front end in?

@humansinstitute, this PR is ready to merge

@humansinstitute
Copy link
Contributor

@Ekep-Obasi - appologies too many changes being merged right now. Can you able to resolve

@Ekep-Obasi Ekep-Obasi force-pushed the feat/feature-flag-module branch from 297884e to cce5cac Compare January 4, 2025 09:09
@Ekep-Obasi
Copy link
Contributor Author

@Ekep-Obasi - appologies too many changes being merged right now. Can you able to resolve

no problem. We can't avoid it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants